Does not name a type even though I made a typedef

[Zipdox]

For some reason I can't compile this code for Arduino.

Code: [Select]

#include <MIDI.h>

#define samplingRate 62500
#define maxPlayingNotes 2

MIDI_CREATE_DEFAULT_INSTANCE();

float midiFrequency(float note){
  return 440*(pow(2, (note-69)/12));
}

typedef struct {
    byte pitch;
    int onTime;
    int offTime;
    int hasBeenOn;
} Note;

Note getNoteTimes(byte pitch, float dutyCycle){
  float period = samplingRate/midiFrequency(pitch);
  Note finalNote = {pitch, round(dutyCycle*period), round((1-dutyCycle)*period), 0};
  return finalNote;
}

volatile Note playingNotes[maxPlayingNotes];



void handleNoteOn(byte channel, byte pitch, byte velocity){
    for(int i = 0; i < maxPlayingNotes; i++){
        if(playingNotes[i].onTime == 0){ // 0 onTime means this note isn't in use
            playingNotes[i] = getNoteTimes(pitch, 0.1);
            break;
        }
    }
    digitalWrite(13, HIGH);
}

void handleNoteOff(byte channel, byte pitch, byte velocity){
    for(int i = 0; i < maxPlayingNotes; i++){
        if(playingNotes[i].pitch == pitch){
            playingNotes[i] = {0,0,0,0}; // 0 onTime means it doesn't play
        }
    }
    digitalWrite(13, LOW);
}

//void handlePitchBend(byte channel, int bend){
//  float bendfactor = (1+ (float) bend/8190);
//  float dutyCycle = 0.1;
//  for(int i = 0; i < maxPlayingNotes; i++){
//      if(playingNotes[i].onTime == 0) continue;
//      float period = samplingRate/(bendfactor * midiNotes[playingNotes[i].pitch]);
//      playingNotes[i].onTime = round(dutyCycle*period);
//      playingNotes[i].offTime = round((1-dutyCycle)*period);
//  }
//}






void setup(){
    for(int i = 0; i<(sizeof(playingNotes)/sizeof(playingNotes[0])); i++){
        playingNotes[i] = {0,0,0,0};
    }
//  playingNotes[0] = getNoteTimes(261.6, 0.1);
//  playingNotes[1] = getNoteTimes(329.6, 0.1);
//  playingNotes[2] = getNoteTimes(392.0, 0.1);
    pinMode(9, OUTPUT);
    pinMode(13, OUTPUT);

  cli(); //stop interrupts
//  TCCR2A = 0; // set Timer/Counter Control Registers (TCCR2A/B) to 0
  TCCR2B = 0;
 
  OCR2A = 0; // = 16000000 / (freq*prescaler) - 1 (must be <256)
  // turn on CTC mode
  TCCR2A |= (1 << WGM21);
  // Set CS01 and CS00 bits for 64 prescaler
  TCCR2B |= (1 << CS20);
  // enable timer compare interrupt
  TIMSK2 |= (1 << OCIE2A);
  sei(); //allow interrupts


  MIDI.setHandleNoteOn(handleNoteOn);
  MIDI.setHandleNoteOff(handleNoteOff);
//  MIDI.setHandlePitchBend(handlePitchBend);
  MIDI.begin(MIDI_CHANNEL_OMNI);
}

void loop(){
    MIDI.read();
}

volatile bool shouldPlay;
ISR(TIMER2_COMPA_vect){

  shouldPlay = false;
 
  for(int i = 0; i < maxPlayingNotes; i++){
    if(playingNotes[i].onTime == 0) continue;
    playingNotes[i].hasBeenOn++;
    if(playingNotes[i].hasBeenOn > playingNotes[i].onTime){
        playingNotes[i].hasBeenOn = -playingNotes[i].offTime;
    }
    if(playingNotes[i].hasBeenOn >= 0){
        shouldPlay = true;
    }
  }

  if(shouldPlay){
    PORTB |= 1 << 1;
  }else{
    PORTB &= ~(1 << 1);
  }





 
//  byte ^= 1 << bit_to_flip;
//  byte &= ~(1 << bit_to_clear);
//  byte |= 1 << bit_to_set;
}

polyphonic_midi_interrupter_pitchbend:19:1: error: 'Note' does not name a type; did you mean 'tone'?
 Note getNoteTimes(byte pitch, float dutyCycle){
 ^~~~
 tone
exit status 1
'Note' does not name a type; did you mean 'tone'?

[klugesmith]

A C instructor I am not. 

Am kind of rusty with typedefs, but don't think you need one here.  What if you skip "typedef" ?

The way you said it,  Note seems to be an instance of a nameless kind of struct.
Don't we need to say something like:

struct Note {
 int x;
 int y;
};
struct Note Note1;
struct Note foo();
int bar( struct Note z );

Maybe the typedef lets you later say Note instead of struct Note, but I'm out of my element here.  STFI!

Here's one reference found immediately with DuckDuckGo:
https://stackoverflow.com/questions/9653072/return-a-struct-from-a-function-in-c

[Zipdox]

A C instructor I am not. 

Am kind of rusty with typedefs, but don't think you need one here.  What if you skip "typedef" ?

The way you said it,  Note seems to be an instance of a nameless kind of struct.
Don't we need to say something like:

struct Note {
 int x;
 int y;
};
struct Note Note1;
struct Note foo();
int bar( struct Note z );

Maybe the typedef lets you later say Note instead of struct Note, but I'm out of my element here.  STFI!

Here's one reference found immediately with DuckDuckGo:
https://stackoverflow.com/questions/9653072/return-a-struct-from-a-function-in-c

It's really weird because it used to work before, but somehow now that I changed some other code it no longer does.

[SteveN87]

Does it work if you add a struct tag? e.g.:

Code: [Select]

typedef struct Note_t {
    byte pitch;
    int onTime;
    int offTime;
    int hasBeenOn;
} Note;


[Zipdox]

Does it work if you add a struct tag? e.g.:

Code: [Select]

typedef struct Note_t {
    byte pitch;
    int onTime;
    int offTime;
    int hasBeenOn;
} Note;


No it doesn't. I also tried doing struct and typedef separately and it also doesn't work. I believe this might be a bug in the compiler because when I tried moving functions around it gave very weird output, there were words joined without spaces ans it was all very confusing. I may file a bug report later.

[klugesmith]

One rite of passage for coders is finding their first compiler bug,
where correct source code does not compile or behaves wrong.

[SteveN87]

Have they changed the default C standard revision to C18? (Maybe knock it down to C11 if so.)

[T3sl4co1l]

Probably a missing semicolon somewhere then.

Also FYI, declarations are usually placed in headers so they are declared at the top right away; doesn't matter if you're only using it in just one file but it is a more organized style.

Tim